[PATCH] extensions: add revset support to most extensions

Greg Ward greg-hg at gerg.ca
Fri Nov 12 16:23:27 CST 2010


On Thu, Nov 11, 2010 at 12:59 PM, Will Maier <willmaier at ml1.net> wrote:
> The patch below adds revset support to all of the extensions that a) seemed to
> need it and b) I could test. Test suite passes here, as do various manual sanity
> checks.

Looks like a reasonable start.  But you really need to modify some
test scripts: e.g. test that 'bookmarks' accepts revsets.  Then test
that 'children' accepts revsets.  Then test that 'extdiff' accepts
revsets.  You get the idea...

If you don't, then someone could inadvertently undo your change and
the tests would still pass.  "Whaddya mean I broke extdiff?  The tests
still passed!"

Greg


More information about the Mercurial-devel mailing list