[PATCH] Fix: prevent gobject._gobject demandimport crash (issue2502)

Alan Franzoni mailing at franzoni.eu
Wed Nov 17 13:28:51 CST 2010


On Wed, Nov 17, 2010 at 8:19 PM, Matt Mackall <mpm at selenic.com> wrote:
> You should instead extend the blacklist from within your application.
> Not only will this mean not having to send us patches, but you can be
> compatible with versions of Mercurial that don't include your patch.

Possible approaches are being discussed in the ticket:

http://mercurial.selenic.com/bts/issue2502

The problem is:

* the error really arises in a python library (keyring) which is used
by a mercurial extension (mercurial_keyring)
* keyring maintainers don't seem prone to accept such a patch since
they think it's got nothing to do with their lib
* mercurial_keyring maintainers chose keyring because it's really an
abstraction library - it lets client code to "forget" what particular
keyring implementation is using, so it really seems an overkill.

I'll try pushing a patch to mercurial_keyring as well, but if it's
bounced again I'll either need to fork or to forget about keyring
credentials caching in mercurial under linux.

-- 
Alan Franzoni
--
contact me at public@[mysurname].eu


More information about the Mercurial-devel mailing list