The 'is' operator and check-code

Martin Geisler mg at aragost.com
Mon Nov 22 11:18:25 CST 2010


Matt Mackall <mpm at selenic.com> writes:

> Relatedly, we should probably not be doing the following:
>
> i18n/polib.py:    if kwargs.get('autodetect_encoding', True) == True:

Pushed 8ea51e9e7031 for this and sent the fix upstream.

> mercurial/revset.py:    if x == None:
> 'if x == True/False/None' should always either be 'if (not) x:' or 'if x
> is True/False/None'.

I have pushed 9aa1e33cff90 to combat this.

-- 
Martin Geisler

aragost Trifork
Professional Mercurial support
http://mercurial.aragost.com/kick-start/


More information about the Mercurial-devel mailing list