[PATCH STABLE V2] opener: do not unlink symlinks on 'w'rite

Adrian Buehlmann adrian at cadifra.com
Fri Nov 26 05:54:50 CST 2010


On 2010-11-26 11:37, Christian Ebert wrote:
> * Adrian Buehlmann on Friday, November 26, 2010 at 10:29:38 +0100
>> On 2010-11-25 23:55, Christian Ebert wrote:
>>> * Adrian Buehlmann on Thursday, November 25, 2010 at 23:40:33 +0100
>>>> # HG changeset patch
>>>> # User Adrian Buehlmann <adrian at cadifra.com>
>>>> # Date 1290708399 -3600
>>>> # Branch stable
>>>> # Node ID 0162f745b6ba9f422e22c71f03b0c7d91a17cacb
>>>> # Parent  dd24f3e7ca9e68a49fd7f38803e4d98469cad6e4
>>>> opener: do not unlink symlinks on 'w'rite
>>>>
>>>> The current code replaces symlinks with a normal file on 'w'rite.
>>>>
>>>> This patch restores the pre 1.7.1 behavior, which preserves symlinks.
>>>
>>> I will try to get on your nerves again ;-) test-hardlinks.t
>>> throws an error with this patch on MacOS X:
>>
>> Nice try indeed (to get on my nerves). But it's hardly a Mac OS X
>> problem :). Read on.
> [...]
>  
>> Yeah. It fails in the same way on Linux if I apply the patch on the
>> default branch :)
>>
>> Please apply it on the stable branch. The patch is for stable, not default.
> 
> As the STABLE flag clearly indicates. Duh. Thank you for the
> reading lesson, and sorry for the noise.

No problem at all.

> And, yes, the test passes in stable, even on MacOS X, and even on
> my machine ;-)

Thank you for testing it.


More information about the Mercurial-devel mailing list