[issue2414] Patchbomb violates RFC 2822

[Dan Villiom Podlaski Christiansen]

New submission from Dan Villiom Podlaski Christiansen <danchr at gmail.com>:

According to RFC 2822[1][2] the body of an email “is simply lines of US-ASCII 
characters.” The patchbomb extension violates this if the patch contains high-bit 
characters, as these are included unencoded in the message.

Please note that issue2290 may be related to this, as the RFC also states that 
“CR and LF MUST only occur together as CRLF; they MUST NOT appear independently 
in the body.”

As with issue2290 this theoretical problem became an actual problem when Apple 
Mail was involved. Somehow, Apple Mail stored the source of the message in 
question as ISO-8859-1, causing the patch to be corrupt and our tests to fail. It 
took us a while to isolate the cause of the tests consistently failing for one 
person, and consistently passing for another.[3]

[1] <http://tools.ietf.org/html/rfc2822#section-2.1>
[2] <http://tools.ietf.org/html/rfc2822#section-2.3>
[3] 
<http://groups.google.com/group/hgsubversion/browse_thread/thread/d6c7fba97ba9d8b
9>

----------
messages: 13815
nosy: danchr
priority: bug
status: unread
title: Patchbomb violates RFC 2822

____________________________________________________
Mercurial issue tracker <bugs at mercurial.selenic.com>
<http://mercurial.selenic.com/bts/issue2414>
____________________________________________________