[PATCH 1 of 2] win32: update Inno Setup build instructions with up-to-date software

Pascal Quantin pascal.quantin at gmail.com
Sun Oct 10 11:56:38 CDT 2010


Hi,

Le 10 oct. 2010 à 18:45, timeless <timeless at gmail.com> a écrit :

> I'm reading 405 hg conversations (summer vacation backlog =1month +
> 1week to read everything else)
> 
> This is a suggestion, and it isn't really a comment on the quality of
> the patch (which I presume has already landed).
> 
> It looks like (based on the first hunk that I've retained) that you've
> dropped support for python <2.6, I'd suggest that you remove all
> references to that path (as noted below). If people really want to go
> that way, they can use hg to read the old notes.

Actually support for Python < 2.6 should still work (even if I have not tested it lately). That's why I did not clean the buld instructions (after all hg still supports older Python releases).
But thanks for your comments. My intent was not to bump the requirements to Python 2.6 but I see why you understood it this way. I will take them into account if we decide to drop support for older Python releases with this installer.

Regards,
Pascal.

> 
> On Sat, Sep 11, 2010 at 7:56 PM, Pascal Quantin
> <pascal.quantin at gmail.com> wrote:
>>  It has the following prerequisites, at least as I build it:
>> 
>> +  Python 2.6 for Windows
>> +      http://www.python.org/download/releases/
> 
> This should probably say 2.6+
> 
>> @@ -15,19 +18,19 @@
>>   mfc71.dll (just download, don't install; not needed for Python 2.6)
>>       http://starship.python.net/crew/mhammond/win32/
> 
> Is this still relevant as you mostly bumped the requirement to python 2.6 above?
> 
>> +  Visual C++ 2008 SP1 redistributable package (needed for >= Python 2.6 or if you compile with MSVC)
>> +      http://www.microsoft.com/downloads/details.aspx?FamilyID=A5C84275-3B97-4AB7-A40D-3802B2AF5FC2
> 
> Shouldn't you be able to drop the parenthetical (as 2.6 is now a requirement)
> 
>> @@ -45,41 +48,37 @@
> 
>>  If you are using Python up to version 2.5.4, copy mfc71.dll into the dist
>>  directory that just got created.
> 
> I'd suggest dropping the python <2.6, unless you really intend to support it.
> 
>> +If you are using Python 2.6 or later, or if you are using MSVC 2008 to compile
>> +mercurial, you must include the C runtime libraries in the installer.
> 
> I'd suggest you change this to simply "You must include the C runtime
> libraries with in the installer."


More information about the Mercurial-devel mailing list