[PATCH] verify/progress: using gerund to indicate action and adding units

Augie Fackler durin42 at gmail.com
Thu Oct 14 11:51:19 CDT 2010


LGTM

On Oct 14, 2010, at 1:05 AM, timeless wrote:

> # HG changeset patch
> # User timeless <timeless at gmail.com>
> # Date 1280722547 -10800
> # Node ID fb2771df0fb88cb35d0d4670f708b4c726d24034
> # Parent  7efaa941b8ca005d20be00d1c21c9bb21c2d0df4
> verify/progress: using gerund to indicate action and adding units
>
> diff --git a/mercurial/verify.py b/mercurial/verify.py
> --- a/mercurial/verify.py
> +++ b/mercurial/verify.py
> @@ -124,7 +124,7 @@ def _verify(repo):
>     checklog(cl, "changelog", 0)
>     total = len(repo)
>     for i in repo:
> -        ui.progress(_('changesets'), i, total=total)
> +        ui.progress(_('checking'), i, total=total,  
> unit=_('changesets'))
>         n = cl.node(i)
>         checkentry(cl, i, n, seen, [i], "changelog")
>
> @@ -135,14 +135,14 @@ def _verify(repo):
>                 filelinkrevs.setdefault(f, []).append(i)
>         except Exception, inst:
>             exc(i, _("unpacking changeset %s") % short(n), inst)
> -    ui.progress(_('changesets'), None)
> +    ui.progress(_('checking'), None)
>
>     ui.status(_("checking manifests\n"))
>     seen = {}
>     checklog(mf, "manifest", 0)
>     total = len(mf)
>     for i in mf:
> -        ui.progress(_('manifests'), i, total=total)
> +        ui.progress(_('checking'), i, total=total,  
> unit=_('manifests'))
>         n = mf.node(i)
>         lr = checkentry(mf, i, n, seen, mflinkrevs.get(n, []),  
> "manifest")
>         if n in mflinkrevs:
> @@ -158,7 +158,7 @@ def _verify(repo):
>                     filenodes.setdefault(f, {}).setdefault(fn, lr)
>         except Exception, inst:
>             exc(lr, _("reading manifest delta %s") % short(n), inst)
> -    ui.progress(_('manifests'), None)
> +    ui.progress(_('checking'), None)
>
>     ui.status(_("crosschecking files in changesets and manifests\n"))



More information about the Mercurial-devel mailing list