[PATCH 0 of 1] subrepo ... how to ...

Mads Kiilerich mads at kiilerich.com
Mon Oct 18 21:15:37 CDT 2010


In http://selenic.com/pipermail/mercurial-devel/2010-October/025138.html I
proposed a fix for propagating non-default pull/push path to subrepos with
relative paths.

Matt accepted hacking the config to avoid transferring extra parameters through
all the layers, but would like to get the old values restored in case somebody
reused the repo object - for example from tortoisehg. That could obviusly
work for pull where we could copy the ui before annotating its config. Push
however also has an ui object, but that is hardly used because the repo object
already has a ui object. These two objects do apparently happen to be the same
ui object, but it makes hacking them very ugly and I don't think that is the
way to go.

I now propose the following patch which in my opinion is the least ugly and
invasive way to do it. But it ain't pretty.

An alternative could be to pass the top path as parameter through the relevant
layers as proposed in the patch on issue1852.

Comments?

/Mads


More information about the Mercurial-devel mailing list