The 1.7 freeze has started!

[Steve Borho]

On Wed, Oct 20, 2010 at 11:00 PM, Steve Borho <steve at borho.org> wrote:
> On Wed, Oct 20, 2010 at 10:11 PM, Steve Borho <steve at borho.org> wrote:
>> On Wed, Oct 20, 2010 at 9:00 PM, TK Soh <teekaysoh at gmail.com> wrote:
>>> On Thu, Oct 21, 2010 at 7:59 AM, Steve Borho <steve at borho.org> wrote:
>>>> On Wed, Oct 20, 2010 at 5:12 PM, Matt Mackall <mpm at selenic.com> wrote:
>>>>> I've merged default into stable. No more commits on the default branch
>>>>> until 1.7 is released (Nov 1), normal rules for stable apply: bug fixes
>>>>> and doc fixes only.
>>>>>
>>>>> Please help us test the upcoming 1.7 release by running builds from the
>>>>> stable branch.
>>>>
>>>> Windows packages of the new stable tip are now available at:
>>>>
>>>> http://bitbucket.org/tortoisehg/thg-winbuild/downloads/
>>>>
>>>> I would especially appreciate if TortoiseHg users would smoke test the
>>>> newer tortoisehg-stable packages because most of our core developers
>>>> are using the 2.0 code base, and thus we won't find many bugs
>>>> ourselves in hgtk.
>>>
>>> Got an error with the installer:
>>>
>>> C:\>hgtk log
>>> Traceback (most recent call last):
>>>  File "hgtk", line 34, in <module>
>>>  File "mercurial\demandimport.pyo", line 115, in _demandimport
>>>  File "zipextimporter.pyo", line 82, in load_module
>>>  File "tortoisehg\util\hgversion.pyo", line 13, in <module>
>>>  File "mercurial\demandimport.pyo", line 81, in __getattribute__
>>>  File "mercurial\demandimport.pyo", line 50, in _load
>>>  File "zipextimporter.pyo", line 82, in load_module
>>>  File "mercurial\util.pyo", line 576, in <module>
>>>  File "mercurial\demandimport.pyo", line 91, in _demandimport
>>>  File "zipextimporter.pyo", line 82, in load_module
>>>  File "mercurial\windows.pyo", line 21, in <module>
>>>  File "mercurial\demandimport.pyo", line 81, in __getattribute__
>>>  File "mercurial\demandimport.pyo", line 50, in _load
>>>  File "zipextimporter.pyo", line 98, in load_module
>>>  File "mercurial\demandimport.pyo", line 128, in _demandimport
>>>  File "mercurial\demandimport.pyo", line 81, in __getattribute__
>>>  File "mercurial\demandimport.pyo", line 48, in _load
>>> ImportError: No module named osutil
>>>
>>
>> The standalone Mercurial installer with tip of stable is similarly broken.
>>
>> Investigating.. these are always fun.
>
> Pruning CC: list.
>
> The traceback in Mercurial looks like this:
>
> C:\thg-winbuild>hg
> Traceback (most recent call last):
>  File "hg", line 35, in <module>
>  File "mercurial\demandimport.pyc", line 81, in __getattribute__
>  File "mercurial\demandimport.pyc", line 50, in _load
>  File "zipextimporter.pyc", line 82, in load_module
>  File "mercurial\util.pyc", line 576, in <module>
>  File "mercurial\demandimport.pyc", line 91, in _demandimport
>  File "zipextimporter.pyc", line 82, in load_module
>  File "mercurial\windows.pyc", line 21, in <module>
>  File "mercurial\demandimport.pyc", line 81, in __getattribute__
>  File "mercurial\demandimport.pyc", line 50, in _load
>  File "zipextimporter.pyc", line 98, in load_module
>  File "mercurial\demandimport.pyc", line 128, in _demandimport
>  File "mercurial\demandimport.pyc", line 81, in __getattribute__
>  File "mercurial\demandimport.pyc", line 48, in _load
> ImportError: No module named osutil
>
> It breaks too early for me to even load an extension to help me debug
> the problem.  However I've found that if I do not enable demandimport
> in the 'hg' script the crashes go away.  Very curious.

Ok, after a rather painful bisect session of:

* get a revision from bisect
* local tag it, build an installer, install it, smoke test
* if good, bisect -g and repeat
* if bad, install known good package, bisect -b, repeat

bisect says:

The first bad revision is:
changeset:   12686:fe31f834a9ff
user:        Dan Villiom Podlaski Christiansen <danchr at gmail.com>
date:        Tue Sep 14 23:00:39 2010 +0200
summary:     demandimport: fix an obscure corner-case.

And indeed if I back out this change on the tip of stable, I can make
a working installer package again.

-- 
Steve Borho