[PATCH] win32text: give deprecation warning

[Dan Villiom Podlaski Christiansen]

On 25 Oct 2010, at 18:29, steve at borho.org wrote:

> @@ -158,9 +158,17 @@
> def forbidcr(ui, repo, hooktype, node, **kwargs):
>     return forbidnewline(ui, repo, hooktype, node, '\r', **kwargs)
>
> +deprwarn = True
> def reposetup(ui, repo):
>     if not repo.local():
>         return
> +    global deprwarn
> +    if deprwarn:
> +        if ui.configbool('win32text', 'warn', True):
> +            ui.warn(_("win32text is deprecated, see "
> +                      "http://mercurial.selenic.com/wiki/Win32TextExtension\n 
> "))
> +        deprwarn = False
> +
>     for name, fn in _filters.iteritems():
>         repo.adddatafilter(name, fn)

This deprecation warning seems to me to be a bit weak. If we really  
want users to migrate to the EOL extension, I think we should a) point  
them to it and b) threaten them that we'll eventually remove win32text.

--

Dan Villiom Podlaski Christiansen
danchr at gmail.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1943 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20101025/ff4e80f5/attachment.bin>