[PATCH 2 of 2] *: kill all unnecessary shebangs

Mads Kiilerich mads at kiilerich.com
Tue Oct 26 06:43:54 CDT 2010


On 10/26/2010 12:24 PM, Dan Villiom Podlaski Christiansen wrote:
> # HG changeset patch
> # User Dan Villiom Podlaski Christiansen<danchr at gmail.com>
> # Date 1288088319 -7200
> # Branch stable
> # Node ID aae2e953d405d3fd359f08b023ff6efa1d37a40e
> # Parent  750fd14e8be4588f4de6803dc0b9376961efdb28
> *: kill all unnecessary shebangs.

General comment: If we are trying to clean up I think it would make 
sense to ensure that we have either all or none of:
* x bit
* hashbang
* __main__ handling (explicit or implicit)

> diff --git a/contrib/setup3k.py b/contrib/setup3k.py
> --- a/contrib/setup3k.py
> +++ b/contrib/setup3k.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
>   #
>   # This is an experimental py3k-enabled mercurial setup script.
>   #
> diff --git a/setup.py b/setup.py
> --- a/setup.py
> +++ b/setup.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
>   #
>   # This is the mercurial setup script.
>   #

Wouldn't it be better to make these executable?

And please don't leave an empty first line after the cleanup.

/Mads


More information about the Mercurial-devel mailing list