[PATCH 0 of 4] pachbomb: only one diffstat confirmation prompt, add --confirm option

Christian Ebert blacktrash at gmx.net
Fri Sep 10 05:10:23 CDT 2010


Sorry, Martin, for drawing/forcing you in the discussion,
aggressive PR politics ;-)

* Christian Ebert on Wednesday, September 08, 2010 at 09:03:53 +0200
> This series refactors patchbomb's diffstat confirmation prompts
> introducing a behaviour change for "hg email --diffstat" and
> adding a --confirm option.
> 
> (The first 2 patches are a resend)
> 
> The first patch allows the localization of the choices
> for patchbomb's diffstat prompt by using ui.promptchoice().
> 
> Patchbomb's custom prompt was completely silent in
> non-interactive mode. The second patch makes it show message and
> prompt by catching potential errors before running it through
> pure ui.prompt().

The first 2 definitely should go in for consistency with other hg
prompts.

> The third patch changes the behaviour of "hg email --diffstat":
> Instead of the confirmation prompts for each message/patch which
> also show the patch description, there is now only one prompt
> showing the series' message details and diffstats.

The problem with this ui-change patch(es) is that one has to try
them out in practice, and I guess not many or no crew members
actually use --diffstat.

Could we try whether --diffstat users will be annoyed by this
change? While also not a --diffstat user myself, my impression
was that the current behaviour overlaps a lot with --test, and is
more confusing than one prompt presenting just the diffstats
without the descriptions.

> The fourth patch adds a --confirm option which presents the same
> prompt as --diffstat, but does not write the diffstats in the
> message bodies.

This one I actually would use myself ... bad argument, I know.

> Thanks to Mads Kiilerich for the valuable input on prompt
> handling in general and the discussion of the diffstat prompt
> behaviour.

Probably a mistake to bring this up myself, but as a last resort
I could try to find testers on the user list. But I'm kind of a
lazy byte ;-)

c
-- 
theatre - books - texts - movies
Black Trash Productions at home: http://www.blacktrash.org/
Black Trash Productions on Facebook:
http://www.facebook.com/blacktrashproductions


More information about the Mercurial-devel mailing list