[PATCH 3 of 4] patchbomb: let diffstat prompt only once with complete summary
mg at lazybytes.net
Fri Sep 10 07:58:03 CDT 2010
Christian Ebert <blacktrash at gmx.net> writes:
> * Martin Geisler on Friday, September 10, 2010 at 14:17:45 +0200
> thx for the feedback, much appreciated. It's just that I carry some
> variation of these patches around for such a long time that I get
> bored of them ...
Yeah, it's tricky with patches like this.
>> Christian Ebert <blacktrash at gmx.net> writes:
>>> # HG changeset patch
>>> # User Christian Ebert <blacktrash at gmx.net>
>>> # Date 1283929208 -7200
>>> # Node ID dfe41fdb339d125f73954d8d43f792152656697d
>>> # Parent 724564c8adb259b88c2f369d08ce967b3a8b3d86
>>> patchbomb: let diffstat prompt only once with complete summary
>>> This changes the behaviour of --diffstat. Before the user was asked
>>> for confirmation of each patch with its description and diffstat,
>>> and a final summary.
>>> Now there is only one prompt right before sending with a final
>>> summary which does not include the patch descriptions, but the
>>> message details and the diffstats:
>>> Final summary:
>>> From: sender
>>> To: recipient(s)
>>> Cc: if present or empty
>>> Bcc: if present or empty
>>> Reply-To: if present or empty
>> I'm not sure what that means, but I would have hoped that Bcc and
>> Reply-To was not shown if they are empty?
>>> + Final summary:
>>> + From: quux
>>> + To: foo
>>> + Cc: bar
>>> + Bcc:
>>> + Reply-To:
>>> + Subject: [PATCH] test
>> But they seems to show up anyway?
> Yes, that's on purpose ;-) Rationale: A prompt is to check
> whether I've forgotten something. Oh! Cc is empty! But I wanted
> to spam mercurial-devel; ok, play it again with Cc ...
Yes, but wouldn't the absense of the Cc: line be enough to tell me that?
Mercurial links: http://mercurial.ch/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the Mercurial-devel