[PATCH 0 of 1] patchbomb: add progress support

Martin Geisler mg at lazybytes.net
Sun Sep 12 13:40:54 CDT 2010


Yuya Nishihara <yuya at tcha.org> writes:

> Martin Geisler wrote:
>> Yuya Nishihara <yuya at tcha.org> writes:
>> 
>> > It adds progress bar to patchbomb, shown during sending emails
>> > or writing mbox files.
>> >
>> > Command output example:
>> > Sending [PATCH 0 of 5] test ...
>> > Sending [PATCH 1 of 5] Create a standard "hello, world" program ...
>> > Sending [PATCH 2 of 5] Create a makefile ...
>> > sending [===============>                                       ] 2/6
>> 
>> That is cool! I tried to update test-patchbomb to make it output the
>> progress bar, but I couldn't figure it out. I added
>> 
>>   $ echo 'progress=' >> $HGRCPATH
>>   $ echo "[progress]" >> $HGRCPATH
>>   $ echo "assume-tty=1" >> $HGRCPATH
>>   $ echo "delay=0" >> $HGRCPATH
>>   $ echo "refresh=0" >> $HGRCPATH
>> 
>> before
>> 
>>   $ hg email -m test.mbox -f quux -t foo -c bar -s test 0:tip
>> 
>> but it didn't give me a progress bar, instead it gave me lots of changes
>> like this:
>> 
>> ERROR: /home/mg/src/mercurial-crew/tests/test-patchbomb.t output changed
>> --- /home/mg/src/mercurial-crew/tests/test-patchbomb.t 
>> +++ /home/mg/src/mercurial-crew/tests/test-patchbomb.t.err 
>> @@ -151,7 +151,7 @@
>>    
>>  
>>    $ hg email -m test.mbox -f quux -t foo -c bar -s test 0:tip
>> -  This patch series consists of 2 patches.
>> This patch series consists of 2 patches.                                        
>> 
>> Can you take a look at it?
>
> Ah, that's because xterm or something interprets control characters of
> diff output. It contains many '\r's.

But despite the number of \r's, I would have expected to see some ===>
lines as well.

> Maybe we need the asciify patch proposed by Mads.

Ah, yeah... please put that in, Mads!

-- 
Martin Geisler

Mercurial links: http://mercurial.ch/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20100912/44d923d5/attachment.pgp>


More information about the Mercurial-devel mailing list