[PATCH 2 of 7] revlog: introduce _chunkbase to allow filelog to override

[Benoit Boissinot]

On Tue, Sep 14, 2010 at 05:54:50PM -0500, Matt Mackall wrote:
> On Tue, 2010-09-14 at 11:56 +0200, Sune Foldager wrote:
> > # HG changeset patch
> > # User Sune Foldager <cryo at cyanite.org>
> > # Date 1284458050 -7200
> > # Node ID 231111b93160405441ee00f0270e7249d931ab8e
> > # Parent  e2fddb22ed181f9ece3b872dbb31292c95e959b1
> > revlog: introduce _chunkbase to allow filelog to override
> > 
> > Used by revlog.revision to retrieve the base-chunk in a delta chain.
> 
> Can't we do this with normal inheritance?

I think it's the case, it's just that we only want to do that when
retrieving a full snapshot.

If we don't separate the cases, the filelog version of chunk will have
to check if it is a base or not, while the caller already knows it.

Both work, it just seems extra work if we don't separate.

regards,

Benoit

-- 
:wq