[PATCH 6 of 7] activate the light-weight copy feature

Matt Mackall mpm at selenic.com
Wed Sep 15 09:19:46 CDT 2010


On Wed, 2010-09-15 at 15:06 +0200, Sune Foldager wrote:
> On 15-09-2010 13:55, Matt Mackall wrote:
> > On Wed, 2010-09-15 at 13:30 +0200, Sune Foldager wrote:
> >> On 15-09-2010 01:01, Matt Mackall wrote:
> >>> This should probably be optional/undocumented until we've sorted out the
> >>> related bundle format issues.
> >>
> >> Ok, but with the stream-patch, there should be no issues, as
> >> changegroups are kept in the existing format and store data is
> >> unpacked/repacked as needed.
> >
> > I won't consider the problem solved until the wire protocol bits are in
> > place and given some testing. Until then, it's an experiment that might
> > fail.
> 
> Hmm, I don't get it. We have plenty of features, like fncache, which 
> affect the local store but stays transparent on the wire. This is pretty 
> much the same. It works locally, and stays transparent over the wire.

Bandwidth is just as important as disk space, if not significantly more
important. So while what you've got so far is nice on its own, it's less
than half-done until the wire protocol supports it.

And if it's not finished, issues may be discovered down the road that
prevent it from being fully finished and mean we have to start over. So
shipping this on by default before then is just reckless.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list