[PATCH] hgweb: add remoteuser to template variables

Dirkjan Ochtman dirkjan at ochtman.nl
Fri Sep 17 02:52:07 CDT 2010

On Fri, Sep 17, 2010 at 05:16, FZiegler <zarf at klacto.net> wrote:
> mpm pointed out a side effect: currently, "If multiple different users hit
> the same hgweb page through a proxy using existing user-less templates,
> they'll get cached copies. The above change will mean they'll all get
> uncached copies of the same bytes."
> If that is a concern, I guess we could try to make the ETag addition
> conditional on some flag to be set in hgweb.config. As mpm said, "Dunno if
> it's worth the trouble", I'm leaving this up for you to judge.

We could make it conditional on REMOTE_USER being set, that would
sufficiently minimize the impact, I think.

Actually, I wonder if we can leverage the HTTP Vary header to fix this
instead of changing the ETag... Maybe you can check that out?



More information about the Mercurial-devel mailing list