[PATCH] hgweb: add remoteuser to template variables

FZiegler zarf at klacto.net
Sun Sep 19 17:13:12 CDT 2010


Here is the status of this, so far as I can tell:

-- First: I couldn't figure out how to avoid the ETag change by using a 
Vary header instead (djc's suggestion). So unless someone else can, I 
see basically 3 options:

1) not change the ETag at all (and let users who need monkey-patch it)
2) change it but only when a flag is set in hgweb.config
3) just keep my patch as is, i.e. always change the ETag by adding '/'
    plus, if set, req.env['REMOTE_USER'].

I think 1) would be half-assed, and I interpret djc's answer here and 
mpm's on irc as saying that they can live with 3), despite the proxy 
impact. But if there is demand for 2), I can try to code that.

-- Second: kiilerix has suggested that instead of adding a keyword for 
this one entry of the req.env dictionary (and potentially others later), 
we could add a mechanism to access them all -- maybe something like

  http://selenic.com/pipermail/mercurial-devel/2010-September/024577.html

If this is the plan, I guess my options are to either implement it, or 
try to make my change at least forward-compatible with it. Either way, I 
would need to know more about, e.g., the desired keyword syntax.

Francois


More information about the Mercurial-devel mailing list