[PATCH] Add a --all option to qfold that fold all unapplied patch in the current one

Mads Kiilerich mads at kiilerich.com
Sat Sep 25 12:46:00 CDT 2010

  Pierre-Yves David wrote, On 09/21/2010 07:07 PM:
> # HG changeset patch
> # User Pierre-Yves David<pierre-yves.david at ens-lyon.org>
> # Date 1285028334 -7200
> # Node ID 1ada9dc8dee5ae2345cf619a6186cff79531c6d3
> # Parent  d0a97814b7d7f7eb6790d00813848dfc9ea82193
> Add a --all option to qfold that fold all unapplied patch in the current one.
> This options is not compatible with explicite patch name.
> The need for such feature have been express on stack overflow:
>      http://stackoverflow.com/questions/3715016/mercurial-qfold-all-patches

I don't think that is a good idea.

The value of this option is very low. The poster on stackoverflow shows 
some alternatives that works just fine - and there is even a windows 
version. It might be nice to have in some situations, but certainly not 

The command is dangerous. It would make it too easy to collapse a set of 
carefully prepared patches. It do especially not deserve a short option.

Because the command is dangerous and non-reversible it would have to be 
documented and described very clearly what it does and how dangerous it is.

My conclusion: Not worth it.


ps: the patch itself looks fine, but note that we always indent 4 spaces

More information about the Mercurial-devel mailing list