[PATCH 0 of 1] hgweb: add environ to template variables

Dirkjan Ochtman dirkjan at ochtman.nl
Sat Sep 25 16:31:21 CDT 2010


On Sat, Sep 25, 2010 at 20:15, Mads Kiilerich <mads at kiilerich.com> wrote:
> Can you say more about why you think it is a bad idea?
>
> Yes, it exposes much stuff to the templates, but it is stuff that already
> has been exposed as environment variables.

Because the templates are supposed to provide an abstraction from
whatever's on the inside. We want loose coupling. Exposing all kinds
of stuff that we don't know about to the templates is just not a good
idea in my mind.

Cheers,

Dirkjan


More information about the Mercurial-devel mailing list