[PATCH] mq: Added return 0 on success

Erik Vest Zielke ez at aragost.com
Mon Sep 27 03:02:29 CDT 2010


On Sun, 2010-09-26 at 18:33 -0400, Greg Ward wrote:
> On Fri, Sep 24, 2010 at 7:53 AM, Erik Zielke <ez at aragost.com> wrote:
> > # HG changeset patch
> > # User Erik Zielke <ez at aragost.com>
> > # Date 1285253792 -7200
> > # Node ID 6b31785388a233be56ac7c994acddc7f89ae3e38
> > # Parent  1f97b741e9a08e73b3281903b335cd2f12094e86
> > mq: Added return 0 on success
> >
> > I have added return 0 on success in docstrings of
> > the different not deprecated mq commands.
> 
> Why?  All well-written Unix commands return 0 on success.  It would be
> more useful to document commands that (incorrectly) return 0 on
> failure.  And even more useful to fix them.  ;-)
> 
> Greg

The reason is to be consistent with the documentation in commands.py,
and show that it is not just by coincidence that the return value is 0,
so users can see that the commands are well-written unix commands.

 



More information about the Mercurial-devel mailing list