[PATCH] mq: Return status of finish command now 1 if no patches applied

Erik Vest Zielke ez at aragost.com
Mon Sep 27 03:15:30 CDT 2010


Okay, I see your point. I were also in doubt.

On Fri, 2010-09-24 at 14:33 -0500, Matt Mackall wrote:
> On Fri, 2010-09-24 at 13:54 +0200, Erik Zielke wrote:
> > # HG changeset patch
> > # User Erik Zielke <ez at aragost.com>
> > # Date 1285253917 -7200
> > # Node ID f540780feaa426182a4bfd8a598899edd412b2e6
> > # Parent  6b31785388a233be56ac7c994acddc7f89ae3e38
> > mq: Return status of finish command now 1 if no patches applied
> 
> Ok, what's your rationale? The current behavior appears intentional, see
> these lines from test-mq.t:
> 
> % does nothing and succeeds
> 
>   $ hg qpop -a
>   no patches applied
> 
> % fails - nothing else to pop
> 
>   $ hg qpop
>   no patches applied
>   [1]
> 
> ie if 'all' is the empty set, then doing nothing is a reasonable
> definition of success.
> 




More information about the Mercurial-devel mailing list