Unstable test output (was: mercurial at 12494: 93 new changesets)

[Thomas Arendsen Hein]

* Mercurial Commits <hg at intevation.org> [20100926 20:50]:
> http://selenic.com/repo/hg//rev/f8dc83689f19
> changeset:   12413:f8dc83689f19
> user:        Matt Mackall <mpm at selenic.com>
> date:        Sun Sep 26 13:41:32 2010 -0500
> summary:     tests: unify test-hup
...
> http://selenic.com/repo/hg//rev/2f8740c639e4
> changeset:   12482:2f8740c639e4
> user:        Matt Mackall <mpm at selenic.com>
> date:        Sun Sep 26 13:44:49 2010 -0500
> summary:     tests: unify test-pull-pull-corruption2

While running all tests (with HGTEST_JOBS=4) I just noticed a timing
problem that does not always occur:

cd tests && python run-tests.py
..........................................s...................s....s...s..s.............................................................................................................................................................
ERROR: /tmp/thomas/crew/tests/test-hup.t output changed
--- /tmp/thomas/crew/tests/test-hup.t
+++ /tmp/thomas/crew/tests/test-hup.t.err
@@ -6,10 +6,10 @@
   $ hg serve --stdio < p &
   $ P=$!
   $ (echo lock; echo addchangegroup; sleep 5) > p &
+  0
+  0
   $ Q=$!
   $ sleep 3
-  0
-  0
   adding changesets
   $ kill -HUP $P
   $ wait
!................................................................................................s.........
ERROR: /tmp/thomas/crew/tests/test-pull-pull-corruption2.t output changed
--- /tmp/thomas/crew/tests/test-pull-pull-corruption2.t
+++ /tmp/thomas/crew/tests/test-pull-pull-corruption2.t.err
@@ -15,7 +15,6 @@
   
   $ hg init version2
   $ hg -R version2 pull source1 &
-  $ sleep 1
   pulling from source1
   requesting all changes
   adding changesets
@@ -23,6 +22,7 @@
   adding file changes
   added 10 changesets with 10 changes to 1 files
   (run 'hg update' to get a working copy)
+  $ sleep 1
   $ hg clone --pull -U version2 corrupted
   requesting all changes
   adding changesets
!................................................
Skipped test-convert-p4-filetypes: missing feature: Perforce server and client
Skipped test-casefolding: missing feature: case insensitive file system
Skipped test-convert-bzr-114.t: missing feature: Canonical's Bazaar client >= 1.14
Skipped test-convert-darcs.t: missing feature: darcs client
Skipped test-convert-p4: missing feature: Perforce server and client
Skipped test-no-symlinks: system supports symbolic links
Failed test-hup.t: output changed
Failed test-pull-pull-corruption2.t: output changed
# Ran 388 tests, 6 skipped, 2 failed.
make: *** [tests] Error 1


-- 
thomas at intevation.de - http://intevation.de/~thomas/ - OpenPGP key: 0x5816791A
Intevation GmbH, Neuer Graben 17, 49074 Osnabrueck - AG Osnabrueck, HR B 18998
Geschaeftsfuehrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner