Committer extension for applying patches
Jason Harris
jason at jasonfharris.com
Sat Apr 2 20:20:42 CDT 2011
This is really neat thanks!!!
One question though to specify both an author and a committer the syntax with this extension is a tiny bit odd, ie:
HGUSER=committer hg commit -u author
it would be nice and clearer to have (1):
hg commit --author John Smith <john at develop.com > --committer Jane Robins <jane at project.com> ...
But then we have the existing 'user' field... So maybe (2):
hg commit --user John Smith <john at develop.com > --committer Jane Robins <jane at project.com> ...
or does this want to be (3):
hg commit --author John Smith <john at develop.com > --user Jane Robins <jane at project.com> ...
I prefer (1) then maybe (2) next...
Actually independent of this extension things are a bit muddled. Since, currently even without this extension, the option used in commit and qrefresh, etc is '--user' yet the keyword for template in log is 'author'. (I didn't really think about this before and I noticed in my MacHg I have used the word 'author', tortiseHg used the word 'user', murky uses 'By', and bitbucket doesn't have a label prefix.)
So do we want '--user' to be a synonym for '--author' and change the syntax of the commit and qrefresh options to use '--author'. (Or maybe we want '--committer' to be a synonym for '--user' and instead add the '--author' option?)
Thus a bare:
hg commit --user John Smith <john at develop.com > ...
would act like
hg commit --author John Smith <john at develop.com > ...
right?
(hg-git should very likely have such functionality built into it right? And if internally everyone agrees that the additional information should be stored in extra['committer'] then all the tools and extensions would interoperate right?)
Cheers,
Jas
On Apr 2, 2011, at 6:49 PM, Eric Eisner wrote:
> As recently discussed: adds the committer extra when you are not the author. Includes revset and template support.
>
> https://bitbucket.org/ede/committer
>
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20110403/112056a8/attachment.htm>
More information about the Mercurial-devel
mailing list