[PATCH 1 of 2] hgweb: follow renames and and copies in file log (issue1576)

[Matt Mackall]

On Tue, 2011-04-05 at 16:43 -0400, Kevin Gessner wrote:
> On Tue, Apr 5, 2011 at 4:30 PM, Matt Mackall <mpm at selenic.com> wrote:
> > On Tue, 2011-04-05 at 10:23 -0400, Kevin Gessner wrote:
> >> # HG changeset patch
> >> # User Kevin Gessner <kevin at fogcreek.com>
> >> # Date 1301949717 14400
> >> # Node ID 2c8959c80e96668c00f836eee93daf48d0fde463
> >> # Parent  086c9f203a53ee4b20a83d06c6e966ecc8a30cbf
> >> hgweb: follow renames and and copies in file log (issue1576)
> >>
> >> When walking the requested filectx finds a rename or copy, recursively walk
> >> that filectx, adding as many changesets as needed, and following renames.
> >>
> >> Known shortcomings: revnavgen can create broken links because it doesn't account
> >> for the different path in older revisions. nodefunc is broken because
> >> it does not map numeric fileids to the correct filectx in allfctx.
> >
> > That's a bit worrisome. I'd rather not move from a well-defined but
> > missing a feature state to a state where we have the feature, but
> > introduce a bunch of conceptual bugs. Do you have any ideas for fixing
> > these things?
> >
> > Your second patch looks like it might address the first concern?
> > Ideally, you arrange things so that it comes first.
> 
> The second patch fixes both shortcomings; after both patches,
> revnavgen works correctly with "--following" file logs. The two
> patches could be folded, or the offending comment could be struck from
> this patch.

Ok, good. The options are:

- send them as one patch
- split and order them in such a way that there's no intermediate
breakage

-- 
Mathematics is the supreme nostalgia of our time.