[PATCH] hgweb: follow renames and copies in file log (issue1576)

[Laurens Holst]

Op 6-4-2011 20:34, Kevin Gessner schreef:
> On Wed, Apr 6, 2011 at 2:21 PM, Matt Mackall<mpm at selenic.com>  wrote:
>> Actually, looks like we recently added something like this to paper (it
>> was in spartan ages ago):
>>
>> http://www.selenic.com/hg/log/30ab5b8ee8ec/mercurial/localrepo.py
>>
>> See the base link on the first revision. Arguably that should link the
>> file log for mercurial/hg.py at that point, rather than the file change
>> view though.
> Yeah, I added the base links to paper and coal last week
> (1209e1d52b68, issue2452); as you noticed, spartan, gitweb, and others
> have long had it (and all link to the file change view, not the log).
>
> So essentially, the base links add "identity" to "position", no? In
> that case, issue2452 fixes issue1576 and this patch isn't needed.

I think you could improve it by adding a ‘Copied from file xxx’ link 
below the lowest changeset, linking directly to the file log of the 
original file.

Some reasons why I think this would be a better user experience:
1. Going directly to the file log is a more logical (and useful) 
browsing continuation.
2. Something underneath the lowest entry is a more logical location for 
people to look; I did not immediately see it in paper or spartan.
3. The term ‘base’ did not ring with me, having a sentence such as 
suggested above would be more clear.

~Laurens

-- 
~~ Ushiko-san! Kimi wa doushite, Ushiko-san nan da!! ~~
Laurens Holst, developer, Utrecht, the Netherlands
Website: www.grauw.nl. Backbase employee; www.backbase.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6034 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20110406/c445864a/attachment.bin>