[PATCH] hgweb: Accessibility improvement for returning help page from its topic pages

Mads Kiilerich mads at kiilerich.com
Wed Apr 13 14:20:41 CDT 2011


Mert Salık wrote, On 04/13/2011 01:40 PM:
> # HG changeset patch
> # User mertsalik
> # Date 1302693762 -10800
> # Node ID 2d12ff67130abe33deaa9b395e9217e7fa13758d
> # Parent  cff56a0ed18ec3d2f7816eccc6ef4ad9ebf3430d
> hgweb: Returning main help page from help topics is difficult and 
> there was no active "/help" link around page. Cross link for Help page 
> added inside of Help header.

See http://mercurial.selenic.com/wiki/ContributingChanges , "patch 
descriptions" and especially "all lines less than 80 characters"

>
> diff -r cff56a0ed18e -r 2d12ff67130a mercurial/templates/paper/help.tmpl
> --- a/mercurial/templates/paper/help.tmpl    Mon Apr 11 21:44:22 2011 
> +0300
> +++ b/mercurial/templates/paper/help.tmpl    Wed Apr 13 14:22:42 2011 
> +0300
> @@ -27,7 +27,7 @@
>
> <div class="main">
> <h2><a href="{url}{sessionvars%urlparameter}">{repo|escape}</a></h2>
> -<h3>Help: {topic}</h3>
> +<h3><a href="/help">Help:</a> {topic}</h3>
>
> <form class="search" action="{url}log">
>  {sessionvars%hiddenformentry}

That is not the place I would look for a link to the main help page. I 
would click on "help" in the menu to the left - but currently I can't.

The currently active menu item do for some reason generally not have a 
link. I think it would be better fix that in all cases - and perhaps for 
all styles.

/Mads



More information about the Mercurial-devel mailing list