[PATCH] paper: use monospace font for parents and children cset id's

Adrian Buehlmann adrian at cadifra.com
Tue Apr 26 14:11:29 CDT 2011


On 2011-04-26 21:03, Kevin Bullock wrote:
> On Apr 25, 2011, at 5:25 PM, Adrian Buehlmann wrote:
> 
>> On 2011-04-25 23:52, Matt Mackall wrote:
>>> On Mon, 2011-04-25 at 23:33 +0200, Adrian Buehlmann wrote:
>>>> # HG changeset patch
>>>> # User Adrian Buehlmann <adrian at cadifra.com <mailto:adrian at cadifra.com>>
>>>> # Date 1303760080 -7200
>>>> # Node ID 399c59a799585be1fbbef12759c062ebe0c52193
>>>> # Parent  da65edcac72af707922917d912ae1969495206d0
>>>> paper: use monospace font for parents and children cset id's
>>>
>>> The rationale for this isn't obvious to me.
>>>
>>
>> It's a matter of taste (as ususal with these things).
>>
>> https://bitbucket.org/abuehl/downloads/downloads/paper-parents-pre.PNG
>> https://bitbucket.org/abuehl/downloads/downloads/paper-parents-post.PNG
>>
>> IMHO, it looks confusing if the changeset hashes don't end at the same x
>> coordinate. It almost looks like they are not the same number of
>> characters.
> 
> If you're going to show the cset ids in monospace, I'd expect e.g. the
> changed filenames to also be in monospace (they're computer
> identifiers). ..

I think the filenames are fine as they are.

>> Bitbucket shows all cset ids as monospace as well.
> 
> ...right next to the commit message, where it makes some stylistic sense
> (to me anyway). But _all_ the metadata in the commit summary box is
> shown in monospace. And this may well have been done simply because
> GitHub did it that way first, rather than any solid design or usability
> reason.
> 
> I'm -1 on the change, but it wouldn't break my heart. :)

The status quo breaks my eyes. Each time I see the child cset much
shorter or longer it feels like there's bug because it looks like short
csets suddenly start having random lengths.

But well. It might be just me.

And taste is not debatable anyway :-)


More information about the Mercurial-devel mailing list