[PATCH 2 of 3 RFC] url: move URL parsing functions into util to improve startup time

Adrian Buehlmann adrian at cadifra.com
Sat Apr 30 09:56:11 CDT 2011


On 2011-04-30 16:06, Brodie Rao wrote:
> # HG changeset patch
> # User Brodie Rao <brodie at bitheap.org>
> # Date 1304172015 25200
> # Node ID 75e0dc9378549f46352bb68ac431cf1a59bf9518
> # Parent  d4fc43e11fad0fcad792320169ae26cfa6297e48
> url: move URL parsing functions into util to improve startup time

[snip]

> --- a/mercurial/util.py
> +++ b/mercurial/util.py

[snip]

> +def readauthforuri(ui, uri):

Layering violation!!! :-)

Usage of ui objects in util is not allowed (as recently explained by
Matt, which lead to that new scmutil module).


More information about the Mercurial-devel mailing list