[PATCH] atomictempfile: make close() consistent with other file-like objects

Greg Ward greg-hg at gerg.ca
Thu Aug 25 15:39:28 CDT 2011


On Thu, Aug 25, 2011 at 4:33 PM, Matt Mackall <mpm at selenic.com> wrote:
> On Wed, 2011-08-24 at 20:21 -0400, Greg Ward wrote:
>> -    def close(self):
>> +    def rename(self):
>> +        warnings.warn('atomictempfile.rename() replaced by close()',
>> +                      DeprecationWarning, 2)
>> +        self.close()
>> +
>
> I'd rather just rip it out entirely.

Fine by me. I'll resend this evening.

Greg


More information about the Mercurial-devel mailing list