[PATCH] Change behavior of "changegroup" hook, make new behavior optional

[Nikolaus.Schueler at lantiq.com]

Hi,

I like Matt's suggestion more, as it emphasizes that the notification comes "from the author" (and not from the system user).

Regards 

Nik

> -----Original Message-----
> From: Benoît Allard [mailto:benoit at aeteurope.nl]
> Sent: Monday, December 12, 2011 11:53 AM
> To: Matt Mackall
> Cc: Schueler Nikolaus (LQKG IT RDS); mercurial-devel at selenic.com
> Subject: Re: [PATCH] Change behavior of "changegroup" hook, make
> new behavior optional
> 
> On 12/9/2011 9:24 PM, Matt Mackall wrote:
> > On Fri, 2011-12-09 at 09:40 +0000, Nikolaus.Schueler at lantiq.com
> wrote:
> >
> >> +    useauthor = ui.config('notify',
> 'changegroup.usefirstcommitter')
> >
> > I can't say I'm thrilled by the option name. I think
> >
> > [notify]
> > fromauthor=True
> >
> > to use the first commit author in the single cset and multiple
> cset case
> > would be better.
> >
> 
> 
> What about:
> 
> [notify]
> from = first
> 
> This way, the option name is the same as in the [email] section.
>