[PATCH] build both 32-bit and 64-bit native extensions on Mac OS X

Brendan Cully brendan at kublai.com
Tue Dec 20 10:51:21 CST 2011


On Tuesday, 20 December 2011 at 10:11, Steven Streeting wrote:
> # HG changeset patch
> # User Steve Streeting <steve at stevestreeting.com>
> # Date 1324375049 0
> # Node ID 5901397ccb8792059a8903fccae22fb788e6e56e
> # Parent  86380f24e6973b5015de67cc53ce7fcfdc9db3ae
> build both intel architectures (x386 and x86_64) on mac with xcode 4
> 
> ARCHFLAGS was being manually set blank to remove ppc for Xcode 4
> (which is no longer supported), but it meant that the native
> extensions would only work on the native architecture of the build
> machine, i.e. either i386 or x86_64, not both. This change sets the
> ARCHFLAGS to include both instead for compatibility (only useful for
> 10.6 or before)

I don't have Xcode 4 on 10.6 to test (is it still possible to download
this?), but manually setting ARCHFLAGS breaks the build when python
doesn't support all the architectures (as is the case with at least
fink's python). So this patch will break mercurial on 10.7 with fink
python. If Xcode 4 on 10.6 is a supported configuration, then this
patch should ensure that it only sets ARCHFLAGS on 10.6.

Also see issue2879 and issue3120.


More information about the Mercurial-devel mailing list