[PATCH] push: propagate --new-branch and --ssh options when pushing subrepos

Matt Mackall mpm at selenic.com
Wed Dec 21 17:28:07 CST 2011


On Tue, 2011-12-20 at 00:04 +0100, Angel Ezquerra wrote:
> # HG changeset patch
> # User Angel Ezquerra <angel.ezquerra at gmail.com>
> # Date 1317309604 -7200
> # Node ID d0193b92f0cb10f6b81b79b9c27012af72946177
> # Parent  21eb048edc19a9b78ae262d222c0de1f3ad6c4d2
> push: propagate --new-branch and --ssh options when pushing subrepos

Queued for default, thanks.

> - Matt suggested that the ssh related flags could also be passed down to
> subrepos during pull and clone. However it seems that it would be the "update"
> command that would need to get those, since subrepos are only pulled on update.
> In any case I'd prefer to leave that for a later patch.

Yes and no. Clone includes an implicit update, and with subrepos, that
update may include implicit clones. So it makes sense to propagate our
clone options when we have them. Also, we should aim for as much
symmetry with push as is reasonable.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list