[PATCH 0 of 4 phases] secret changeset creation and exchange

[Laurens Holst]

Op 22-12-2011 0:19, Matt Mackall schreef:
> I think I'd rather introduce a command to manipulate phases manually
> (which we'll already need) rather than introduce command line options to
> a bunch of commands.

Problem with that is that for a (short) period of time the changeset 
will be public. If you are making secret commits to a publicly 
accessible repo, someone might’ve pulled it already. For something to be 
truly secret, it needs to be that from the start.

A --secret flag on commit is a lot nicer than --config 
phases.new-commit=secret. It will be easier to remember, and show up in 
hg help commit.

> If I do a commit with no options on top of a secret changeset, what
> happens? Do we inherit the secret state?

I think that’s the right thing to do. A secret changeset shouldn’t be 
able to become public without expressly marking it as such. That would 
lead to accidents.

Follow-up question: if I push a secret changeset to a public repo (‘hg 
push -r mysecret’), should it become public? What if I push it to a 
regular (non-public) repository?

~Laurens

-- 
~~ Ushiko-san! Kimi wa doushite, Ushiko-san nan da!! ~~
Laurens Holst, developer, Utrecht, the Netherlands
Website: www.grauw.nl. Working @ www.roughcookie.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4332 bytes
Desc: S/MIME cryptografische ondertekening
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20111222/d8cd07d4/attachment.bin>