[PATCH] add support for marking changesets as dead

[Martin Geisler]

Matt Mackall <mpm at selenic.com> writes:

> On Wed, 2011-02-02 at 10:35 +0100, Martin Geisler wrote:
>> Matt Mackall <mpm at selenic.com> writes:
>> 
>> > On Tue, 2011-02-01 at 21:41 -0200, Wagner Bruna wrote:
>> >
>> >> IMHO it'd be far less confusing for new users if changeset metadata
>> >> were also used for "abandoning" topological heads, since it is very
>> >> similar in concept (and possibly implementation) to closing named
>> >> branches (to some extent, closing a named branch and reopening it at
>> >> another point can be used right now for "abandoned" topological
>> >> lines).
>> >
>> > The similarity between closed and abandoned branches is very
>> > superficial. Closed branches stay in history; abandoned ones are
>> > dropped from history, presumably the sooner the better. We should
>> > probably make an effort to hide abandoned changesets from users
>> > while they're still present, in which case the only thing storing
>> > the marks as changesets serves to do is confuse people using older
>> > hg with weird csets.
>> 
>> Ehm, you say "abandoned ones are dropped from history" and that is
>> not the case at all. Did you misunderstand the idea of abandoned/dead
>> changesets?
>
> If I clone a repo with cset x marked abandoned, I do not get x in my
> clone, yes? And people who already have x get the mark when they pull,
> yes? And when the mark is present, the marked changesets disappear
> from log, yes?

Yes on all three accounts.

> So the abandoned changesets (and not the marks) are effectively (if
> not physically) dropped from history. They are no long visible or
> transmitted, but they still take up space on (some) disks. If that's
> not the idea, then yes, I am indeed confused.

Sorry, you are not confused!

My remark was triggered by you saying that the dead heads are different
from closed heads, when they are infact pretty similar. That was with
the current patch that uses changesets as markers -- with pushkey they
are no longer as similar.

-- 
Martin Geisler

aragost Trifork
Professional Mercurial support
http://aragost.com/en/services/mercurial/blog/