[PATCH] diffstat: fix parsing of filenames

Matt Mackall mpm at selenic.com
Fri Feb 4 13:04:17 CST 2011


On Fri, 2011-02-04 at 05:01 -0300, Gastón Kleiman wrote:
> On Tue, Feb 1, 2011 at 17:39, Gastón Kleiman <gaston.kleiman at gmail.com> wrote:
> > On Tue, Feb 1, 2011 at 17:26, Gastón Kleiman <gaston.kleiman at gmail.com> wrote:
> >> On Tue, Feb 1, 2011 at 17:07, Matt Mackall <mpm at selenic.com> wrote:
> >>> On Tue, 2011-02-01 at 15:39 -0300, Gastón Kleiman wrote:
> >>>> # HG changeset patch
> >>>> # User Gastón Kleiman <gaston.kleiman at gmail.com>
> >>>> # Date 1296582352 10800
> >>>> # Branch stable
> >>>> # Node ID 0f59f053726484df622651a51c18309f700404b2
> >>>> # Parent  a939f08fae9c4a51cc9bf4b3d9c512703856df84
> >>>> diffstat: fix parsing of filenames
> >>>>
> >>>> This patch fixes the parsing of filenames which contain spaces.
> >>>
> >>> It'd be massively helpful if you told us what precisely you think was
> >>> wrong, preferably with before and after examples. For all I can tell
> >>> from your description, whatever you're fixing may actually have been
> >>> that way intentionally.
> >>
> >> I've included some tests in the patch, but you are right that the
> >> description wasn't verbose enough.
> >>
> >> The current stable version of Mercurial has the following behavior:
> >> [...]
> >>
> >> I hope that this description is complete enough, but just tell me if
> >> you need something else =)
> 
> It seems that this thread has died, but I am still wondering whether
> you think that the behavior my patch changes is intentional or not.
> 
> Should I resend the patch with a better description summarizing the
> last two mails I've sent?

Please.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list