[PATCH 0 of 5] using ctypes on Windows

[Patrick Mézard]

Le 12/02/11 18:45, Adrian Buehlmann a écrit :
> On 2011-02-08 17:52, Adrian Buehlmann wrote:
>> The first patch ports win32.py to using Python's ctypes library
>> on Windows (replacing pywin32).
>>
>> The remaining patches are some followup refactorings.
>>
>> The patches can also be pulled with
>>
>>   hg pull -r ad3db71cb3d3 https://bitbucket.org/abuehl/mercurial-crew
>>
>> I've built Windows msi installers
>>
>>   mercurial-unstable-ad3db71cb3d3-abuehl-ctypes-1-x86.msi
>>   mercurial-unstable-ad3db71cb3d3-abuehl-ctypes-1-x64.msi
>>
>> and uploaded these at
>>
>>   https://bitbucket.org/abuehl/mercurial-crew/downloads
>>
>> I've manually tested these on pristine installs of Windows 7 x64
>> and Windows XP SP3 x86.
>>
>> Mercurial testsuite ran ok on Ubuntu Linux (as always when I send
>> a patch).
>>
>> I recommend to include these patches in Mercurial 1.8.
> 
> Any chance this could go in for 1.8 before the feature freeze?
> 
> I still recommend to take this series. It was quite some work to do
> (e.g. lots of manual testing).
> 
> The (IMHO suboptimal) alternative is making pywin32 mandatory. Which
> would be strange if we later switch to ctypes anyway, which I think will
> happen anyway sooner or later.
> 
> Is there something left needed from my side to get this in? What can I
> do to convince you?
> 
> I haven't seen any convincing arguments against this series so far.

In theory, I am all for this series.

In practice, it seems to need more testers but we can probably fix things before the code freeze. I will start using it on Windows XP right now. I have also added it to my Windows test bot patch queue, which does not mean a lot but who knows it may pick some issues (even if it is a Windows 2003 Server). And I will try to read it more thoroughly even if I am not a ctypes nor Windows 64 bits specialist.

Thanks for all the work.

--
Patrick Mézard