[PATCH] localrepo: abort commit if a subrepo is modified and ui.commitsubs=no

Aaron Cohen aaron at assonance.org
Tue Feb 15 16:33:44 CST 2011


On Tue, Feb 15, 2011 at 3:51 PM, Patrick Mézard <pmezard at gmail.com> wrote:
> Le 15/02/11 06:40, Kevin Bullock a écrit :
>> On 14 Feb 2011, at 8:02 PM, Mads Kiilerich wrote:
>>
>>> Kevin Bullock wrote, On 02/14/2011 08:31 PM:
>>>> On Feb 14, 2011, at 9:34 AM, Mads Kiilerich wrote: I think it
>>>> would be confusing and frustrating to more users to embed this
>>>> toggle into .hgsub than in a config setting (particularly if said
>>>> config setting was commitsubrepos=False by default).
>>>
>>
>
> 2- I think the current default is wrong and makes it harder to discuss this issue. Imagine the default were "commitsubrepos=no", I and Mads would be happy, Aaron wouldn't but we would be able to say something like: "the default is safe, if you want to take the risk to commit all kind of stuff automatically, you can just put commitsubrepos=yes in your .hg/hgrc or .hgrc but that's up to you and your conscience". Unfortunately, unless Matt suddenly decides to trample his backward compatibility principles, this is not going to change :-). And after saying this, I feel Mads primary reason to push this into .hgsub is a subtle way to make it the default in his/my own world (which would be great but...)
>

Would it make sense to add a [-S | --subrepos] option to commit, so
that it complements status? I'd be more amenable to arguments about
what the default should be for commitsubrepos if that existed.

My top level super-project would want the recursive options always on,
but I can buy that that's unusual.

--Aaron


More information about the Mercurial-devel mailing list