[PATCH] rollback: clarifies the message about the reverted state (issue 2628)

timeless timeless at gmail.com
Thu Feb 17 02:34:31 CST 2011


On Thu, Feb 10, 2011 at 10:13 AM, Dirkjan Ochtman <dirkjan at ochtman.nl> wrote:
>> Previously, when rolling back a transaction, some users could be confused
>> between the level to which the database is rolled back, and the new parents
>> of the working directory.

> I think it would be interesting to see how we can improve on this
> message, but I don't care much for your current suggestion. I don't
> think we use the word "database" anywhere else for the repo data, and
> the message about the working dir seems to indicate that I now have a
> clean checkout, whereas I actually have the modifications from the
> just-rolled back changeset in it.

Repository tip rolled back to revision <x> (undo <y>)

Because what we're actually affecting is <repository tip>. I know we
don't want to introduce new instances of <tip>, but in this case it's
actually correct.


More information about the Mercurial-devel mailing list