[PATCH] convert/svn: Abort operation when python bindings are not available

Azhagu Selvan SP tamizhgeek at gmail.com
Fri Feb 18 22:49:08 CST 2011


On Fri, 2011-02-18 at 20:48 +0100, Mads Kiilerich wrote:

> Thanks for the patch, but I'm afraid this approach won't work.
> 
> The import has to fail silently here, and the missing libraries should 
> be caught later in the svn_source constructor where it tries to access 
> SubversionException.

Ah sorry! I didn't notice this code.

> 
> I guess it is your experience that it doesn't happen that way? What do 
> you see - and can you figure out exactly why it doesn't work as intended?
> 
> /Mads


Yes. Actually the import transport statement is inside the top level try
block. So when the svn import fails, the 'import transport' never
executes and it raises exception at line no.1009., Where it tries to
access the transport module. May be moving the 'import transport' line 
out of the try block should do fine?


-- 
Azhagu Selvan SP

http://azhaguselvan.co.cc



More information about the Mercurial-devel mailing list