[PATCH] convert/svn: Abort operation when python bindings are not available

Azhagu Selvan SP tamizhgeek at gmail.com
Sun Feb 20 01:14:22 CST 2011

On Sun, 2011-02-20 at 02:31 +0100, Mads Kiilerich wrote:

> No. transport.py will unconditionally import svn, so it has to be 
> imported in the try/except ... at least in principle ...

Ok. Understood

> (The confusing exception is that demandload usually will delay the 
> exception to the first time the imported module is used. We must make 
> sure that doesn't cause trouble in either direction. The import from 
> svn.core will however not be delayed and it will fail immediately if it 
> fails.)


> I think the best and most maintainable solution is to set svn to None if 
> the imports fails and then make sure that all (2?) relevant entry points 
> fails properly "if not svn" (insteaf of accessing SubversionException).
> Will you create, test and post another patch with something like that?
> /Mads

Sure will do.

Azhagu Selvan SP


More information about the Mercurial-devel mailing list