[PATCH] test-push-http: use killdaemons.py instead of kill to avoid test unreliability

Gilles Moris gilles.moris at free.fr
Sun Feb 20 12:25:05 CST 2011


On Sunday 20 February 2011 06:42:53 pm Matt Mackall wrote:
> On Sun, 2011-02-20 at 18:07 +0100, Gilles Moris wrote:
> > # HG changeset patch
> > # User Gilles Moris <gilles.moris at free.fr>
> > # Date 1298221565 -3600
> > # Node ID 9cace2bd206528bab4e522d3967ee81dfe267a60
> > # Parent  643b8212813e631b5525049fc4321a34a4def105
> > test-push-http: use killdaemons.py instead of kill to avoid test
> > unreliability
>
> Queued, thanks.

It seems that a bunch of them remains:

$ grep ' kill ' *.t
test-bad-pull.t:  $ kill $!
test-bookmarks-pushpull.t:  $ kill `cat ../hg.pid`
test-hgweb-raw.t:  $ kill `cat hg.pid`
test-http-branchmap.t:  $ kill `cat hg.pid`
test-https.t:  $ kill `cat hg1.pid`
test-hup.t:  $ kill -HUP $P
test-inotify-debuginotify.t:  $ kill `cat hg.pid`
test-inotify-issue1208.t:  $ kill `cat hg.pid`
test-inotify-issue1371.t:Are we able to kill the service? if not, the service died on some error
test-inotify-issue1371.t:  $ kill `cat hg.pid`
test-inotify-issue1542.t:Are we able to kill the service? if not, the service died on some error
test-inotify-issue1542.t:  $ kill `cat hg.pid`
test-inotify-issue1556.t:Are we able to kill the service? if not, the service died on some error
test-inotify-issue1556.t:  $ kill `cat hg.pid`
test-inotify-lookup.t:  $ kill `cat .hg/inotify.pid`
test-inotify.t:  $ kill `cat ../hg2.pid`
test-inotify.t:  $ kill `cat hg.pid`
test-pull-http.t:  >     kill `cat hg.pid`
test-static-http.t:  $ kill $!

Some seems on purpose like most of the inotify ones or test-hup.t.
I don't have currently any test failing because of that, so may be that
should wait a post 1.8 patch. What do you think?

Regards.
Gilles.


More information about the Mercurial-devel mailing list