[RFC] Amend commit messages
Laurens Holst
laurens.nospam at grauw.nl
Wed Feb 23 07:36:52 CST 2011
Op 23-2-2011 14:29, Didly schreef:
> I totally disagree. Perhaps having a typo in the commit history is
> bad, but what if you realize that you mention the wrong Change
> Request? There are automated tools that use this sort of information
> to tell whether a CR is done or has been worked on and an invalid
> commit message can be disastrous.
But when you’ve pushed surely it’s already too late? Your incoming hooks
will already have updated the bugs to the new state.
> Another scenario where this may come handy is when the commit message
> says something that is later found out to be untrue, such as when it
> says: "Fixed such bug" and later on you discover that this is not the
> case.
Is it really so important to correct this kind of mistake?
> Plus, "How do I fix my commit message" is probably the #1 question I
> get as the person in charge of mercurial supporting in my company, so
> a clean answer to that question would make me very happy :-)
But there is an answer. Rollback is super-easy. Just not after you’ve
pushed.
~Laurens
--
~~ Ushiko-san! Kimi wa doushite, Ushiko-san nan da!! ~~
Laurens Holst, developer, Utrecht, the Netherlands
Website: www.grauw.nl. Backbase employee; www.backbase.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6034 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20110223/5dbc4086/attachment.bin>
More information about the Mercurial-devel
mailing list