hg status and intermediate file changes

[Mads Kiilerich]

On 02/24/2011 04:15 PM, Jason Harris wrote:
>
> On Feb 24, 2011, at 3:45 PM, Mads Kiilerich wrote:
>
>> On 02/24/2011 03:13 PM, Jason Harris wrote:
>>> but what was the answer to the main question in my previous email? Ie the answer to the question summarized by:
>>>
>>>> So in conclusion, basically I can see *lots* of upside / use of status showing the differences between start and end revisions. What are the upsides / use of  status showing the intermediate changes?
>>
>> Well ... I have shared my opinion and tried to explain, and now I don't have more to add ;-)
>>
>> Stat shows manifest changes and is thus fast. Diff shows content changes and thus has to do significantly more work and is slower. I don't think it is a good idea to blur that distinction.
>
>
> Thanks :)
>
> Someone had of course previously had the compare in their in the past and so was doing the compare (it just isn't / wasn't functioning correctly...). (Tracing through lots and lots of peoples commits who have touched that code (looks like about 10 or so people) including Matt, etc. (I stopped tracing once I got back to revision 1616 which was 5 years ago.) In summary all the previous authors have all left the compare in there...

The check was introduced back when the same code was used to compute 
status relative to the working directory. Later refactorizations 
maintained the correct behavior but made that comparison unreachable and 
redundant. AFAICS.

/Mads