[PATCH] convert.svn: branch name which equals trunk means `default' branch (issue2653)

[Mads Kiilerich]

On 02/24/2011 09:05 PM, Augie Fackler wrote:

> Sorry, was looking at old messages first. This could be done more succinctly as:
>
> if branch == self.ui.config('convert', 'svn.trunk', 'trunk').strip('/'):
>
>>                      branch = ''
>>              except IndexError:
>>                  branch = None
>> diff -r 643b8212813e -r 98fb11886cb5 tests/test-convert-svn-mytrunk.t
>> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
>> +++ b/tests/test-convert-svn-mytrunk.t	Thu Feb 24 21:00:22 2011 +0300

And if you will take another round and achieve perfection:

It would be better if the test could be added to or integrated into an 
existing test so the setup overhead could be minimized.

And we still need some documentation for hg help convert.

Now the patch looks fine, but what do the svn experts say: does it make 
sense?

/Mads