[PATCH 1 of 2 STABLE] mq: qpush fails with infinite recursion in _findtags when status file is wrong (issue2664)

Matt Mackall mpm at selenic.com
Mon Feb 28 00:29:17 CST 2011

On Mon, 2011-02-28 at 06:23 +0200, timeless wrote:
> i did:
> d) add a test which will prevent people from doing it again (if they run tests).

Oops, so you did.

Ok, I guess the ball is in my court to fix this all up.

Some asides about tests: for simple bugfixes, it's best to just have one
patch. For bigger changes, it's ok to add -new- tests in patch at the
end, but changes to existing tests should be rolled into the patch that
introduces them.

Mathematics is the supreme nostalgia of our time.

More information about the Mercurial-devel mailing list