Locking bug (double release) between pull() and addchangegroup()

Matt Mackall mpm at selenic.com
Tue Jan 4 15:33:20 CST 2011


On Tue, 2011-01-04 at 15:38 -0500, Greg Ward wrote:
> I'm writing a custom script that does a pull along with many
> updates/merges/commits in the same process.  I think the locking
> semantics between localrepository.pull() and addchangegroup() are
> broken.  In particular, addchangegroup() releases a lock that it did
> not allocate.  Here's a sketch, all from localrepo.py (current
> stable):

This sounds familiar. Suggest you do some archaeology with annotate.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list