Improvement to how subrepos are found?

[Martin Geisler]

Matt Mackall <mpm at selenic.com> writes:

> On Tue, 2011-01-04 at 22:13 +0100, Mads Kiilerich wrote: 
>
>> More important: Changing existing behavior in subtle ways is probably
>> not an option - especially considering how hard it is to recover from
>> subrepo inconsistencies. I think the noble goal should be reached in
>> another way.
>
> I think before we do _anything_ else in this area, we need a better
> test infrastructure for this path handling logic. Every change here
> breaks some old assumption.

I'm afraid you might be right about that...

> I think the right way to do this is to route all the path handling
> logic to a simple function that operates only on strings (and not on
> repos) and thus can be tested painlessly and extensively with doctest.

I like that idea a lot -- I'm a fan of doctest :)

My client hasn't come back to me yet to tell me if this is something
they consider to be very important and thus something they want me to
spend time on, so I wont push it too hard yet. I just wanted to hear
people's opinion about this first.

-- 
Martin Geisler

aragost Trifork
Professional Mercurial support
http://aragost.com/en/services/mercurial/blog/