[PATCH] convert: show exception name when repository conversion fails

anatoly techtonik techtonik at gmail.com
Fri Jan 7 10:54:12 CST 2011


On Fri, Jan 7, 2011 at 6:07 PM, Mads Kiilerich <mads at kiilerich.com> wrote:
> On 01/07/2011 04:10 PM, anatoly techtonik wrote:
>>
>> # HG changeset patch
>> # User anatoly techtonik<techtonik at gmail.com>
>> # Date 1294412623 -7200
>> # Node ID 6200fa4ca6200470de58a943f95cb2577579f4c3
>> # Parent  f3058dd052819de75908599d93a29241ba69318f
>> convert: show exception name when  repository conversion fails
>
> There is a spurious DEL character between 'when' and 'repository'.

I'm using plain windows notepad for editing message. No idea this how
this character got there. Should I resubmit patch? Can you give a hint
how to edit commit message? I can't remember any quick way.

>> diff -r f3058dd05281 -r 6200fa4ca620 hgext/convert/convcmd.py
>> --- a/hgext/convert/convcmd.py  Fri Dec 31 17:09:38 2010 -0600
>> +++ b/hgext/convert/convcmd.py  Fri Jan 07 17:03:43 2011 +0200
>> @@ -58,7 +58,7 @@
>>              exceptions.append(inst)
>>      if not ui.quiet:
>>          for inst in exceptions:
>> -            ui.write("%s\n" % inst)
>> +            ui.write("%s: %s\n" % (inst.__class__.__name__, inst))
>>      raise util.Abort(_('%s: missing or unsupported repository') % path)
>>
>>  def convertsink(ui, path, type):
>
> Can you give an example of the output before and after this patch?

C:\svnrep>hg -v -v --debug --traceback convert -s svn svn

Before:
assuming destination svn-hg
initializing destination svn-hg repository
Subversion python bindings could not be loaded
...
  File "C:\~env\VCS\Mercurial\library.zip\hgext\convert\convcmd.py",
line 62, in convertsource
Abort: svn: missing or unsupported repository
abort: svn: missing or unsupported repository

After:
assuming destination svn-hg
initializing destination svn-hg repository
MissingTool: Subversion python bindings could not be loaded
Traceback (most recent call last):
...
  File "C:\~env\VCS\Mercurial\library.zip\hgext\convert\convcmd.py",
line 62, in convertsource
Abort: svn: missing or unsupported repository
abort: svn: missing or unsupported repository

-- 
anatoly t.


More information about the Mercurial-devel mailing list