[PATCH 0 of 8] Move bookmarks extension to core

[Henrik Stuart]

On 2011-01-17 17:36, Giorgos Keramidas wrote:
> On Mon, 17 Jan 2011 08:23:39 +0100, Peter Arrenbrecht <peter.arrenbrecht at gmail.com> wrote:
>> On Sun, Jan 16, 2011 at 11:57 PM,  <dsp at php.net> wrote:
>>> I did not yet restrict the possible characters for bookmark names. Maybe we want
>>> to restrict the available character for names.
>>
>> I would. Something like [-/.a-zA-Z0-9]. And maybe no leading digits.
>> The reason I include / is so one can use schemes similar to git's (as
>> far as I understand them).
> 
> There are projects that use tag names like "RELENG_2_1_0" out there
> (e.g. FreeBSD is one of them).  It's also possible that non-English
> people may want to use bookmark names in their own native language, as
> long as it's encodable as UTF-8.
> 
> I may be speaking for a small minority of people now, but it would be
> really nice if we don't artificially enforce obstacles on people who
> might want to use tag or bookmark names like "Κεραμίδας" (my last name,
> in UTF-8 Greek script).
> 
> If we restrict tag names, I'd probably go with something more liberal,
> e.g. something like:
> 
>     Everything except for '\r', '\n' and '\0' is ok.

We should definitely allow non-ascii characters; I'd propose we do what
we do for branch names, plus a bit more, i.e., disallow "tip", ".", and
"null", and disallowing [\r\n\t\v\0] seems prudent as well, however,
both tag and branch just disallows (tip|\.|null) so that should be the
least that bookmarks disallows.

-- 
Kind regards,
  Henrik Stuart